lizhimins commented on PR #7307: URL: https://github.com/apache/rocketmq-dashboard/pull/7307#issuecomment-6434004308
Closing this one. Bulk acknowledgement itself is well tested, and the endpoint is a reasonable thing to want. Three things block it as submitted: 1. The new `POST /system-alerts/acknowledge-all` endpoint is missing from `docs/api-spec.md`, which is the contract reference for the whole REST surface. 2. The `unackCount` gate counts only the rows loaded on the current page, so a deliberately cross-page action is unreachable from any page after the first. It needs a server-side unacknowledged total, or no gate at all. 3. It conflicts with #7021 in `AlertServiceTest` and would need a rebase and a re-run of that suite. Item 2 is a design decision rather than a mechanical fix, so we are closing rather than holding it. A resubmission with the api-spec row added and the gate either server-side or removed would be welcome. The linked issue #6160 is already closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
