lizhimins commented on PR #5616:
URL:
https://github.com/apache/rocketmq-dashboard/pull/5616#issuecomment-6434928932
Closing this one: the trunk already fixed the same line, in a way that
survives translation.
#4641 (merged as `ec3c55505`) changed `alerts.tsx` to render the pagination
total through a new i18n key, `alerts.totalRulesWithCount`, which carries a
`{count}` placeholder in both locales - `共 {count} 条规则` and `{count} rules
total` - and added tests for it.
This PR targets the same `showTotal` callback but interpolates in the
template string instead (`${t('alerts.totalRules')} ${total}`), which
hard-codes label-then-count word order and would read wrong in any locale that
puts the count first. The added test also still passes with the fix reverted,
so it does not pin the behaviour. It additionally drops the trailing newline at
the end of `alerts.tsx`.
So there is nothing left to land here - thanks for spotting the original
problem, it did get fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
