lizhimins commented on PR #6987:
URL: 
https://github.com/apache/rocketmq-dashboard/pull/6987#issuecomment-6433495204

   Closing this one: the premise does not hold on the production path.
   
   The only production caller passes `builder.environment()`, which is already 
case-insensitive on Windows, so `Path` / `SystemRoot` are retained regardless 
of how the parent environment spells them. Switching to a case-insensitive 
`TreeMap` and iterating the parent environment therefore does not change 
observable behaviour - the added tests pass with and without the production 
change.
   
   If you have a Windows reproduction where a variable really is dropped, 
please reopen with that scenario and we will take another look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to