lizhimins commented on PR #5886:
URL: 
https://github.com/apache/rocketmq-dashboard/pull/5886#issuecomment-6443332983

   Merged as part of #5918 - squashed into `rocketmq-studio` as `2df0a70e1`.
   
   Your change here (writing the `user` and `session` audit columns explicitly 
from `AuthService.now()` instead of leaving them to database defaults, so the 
recorded instant is UTC like the rest of the auth path. This one needed the 
most work to land: #7311 had started surfacing `gmt_create` to the UI, and the 
write points added since you opened the PR (#7311, #7312) had to be covered 
too, so all 13 write points now stamp explicitly rather than half the table 
being UTC and half the database default. The four `AuthService` conflicts were 
resolved as a union, keeping #7312's `passwordMustChange` and #7230's monotonic 
`last_seen_at` guard, and the two test conflicts were stitched back into five 
complete test methods.) is included.
   
   We grouped 6 of your related fixes into a single commit so the trunk history 
stays reviewable; the other PRs in the group are closed with the same note. 
Everything was cherry-picked onto the current baseline with you kept as the 
author, and your tests came along with the change - the combined branch runs 
4157 backend tests and 2016 frontend tests across 166 files green, with the 
build, type check, license and lint gates clean.
   
   Where the note above says "we", that part was added while landing the batch; 
the rest is yours unchanged. Thanks for the consistently well-tested patches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to