lizhimins commented on PR #5920: URL: https://github.com/apache/rocketmq-dashboard/pull/5920#issuecomment-6443340271
Merged as part of #5918 - squashed into `rocketmq-studio` as `2df0a70e1`. Your change here (propagating the availability flag the backend already sends through `metadata.ts`, `consumerService.ts` and `consumerGroupDiagnostics.ts`, rendering "unavailable" at all five consumption points, and sorting unmeasured rows to the bottom in both directions. While landing it we added the ascending-sort assertion the review asked for - without it the `MAX_SAFE_INTEGER` branch of the local `delaySortValue` had no coverage - and fixed a line-wrap in your own `consumerService.test.ts` that failed prettier. The two optional items (an api-spec field row and a mock fixture flag) were left out; tell us if you want them.) is included. We grouped 6 of your related fixes into a single commit so the trunk history stays reviewable; the other PRs in the group are closed with the same note. Everything was cherry-picked onto the current baseline with you kept as the author, and your tests came along with the change - the combined branch runs 4157 backend tests and 2016 frontend tests across 166 files green, with the build, type check, license and lint gates clean. Where the note above says "we", that part was added while landing the batch; the rest is yours unchanged. Thanks for the consistently well-tested patches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
