lizhimins commented on PR #6865:
URL:
https://github.com/apache/rocketmq-dashboard/pull/6865#issuecomment-6441476486
Merged as part of #6851 - squashed into `rocketmq-studio` as `da2513c9f`.
Your change here (keeping a reader account out of the AI, data source and
cloud credential write paths. While landing it we did the two things review
asked for: the derivation now lives in one shared `useCanWriteSettings` hook
instead of four copies, and the gate is checked before the submitting lock so a
rejected attempt cannot leave the modal permanently locked. The conflict with
#6926 and #7199 in `DataSourceTab.tsx` is resolved keeping both -
`onCancel={closeModal}`, `resetModalTest()` and the `submittingRef` guard are
all intact.) is included.
We grouped 11 of your related fixes into a single commit so the trunk
history stays reviewable; the other PRs in the group are closed with the same
note. Everything was cherry-picked onto the current baseline with you kept as
the author, and your tests came along with the change - the combined branch
runs 4143 backend tests and 2009 frontend tests green, with the catalog,
license and lint gates clean.
Where the note above says "we", that part was added while landing the batch;
the rest is yours unchanged. Thanks for the consistently well-tested patches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
