yx9o commented on code in PR #11310:
URL: https://github.com/apache/rocketmq/pull/11310#discussion_r4434402101
##########
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java:
##########
@@ -1387,7 +1387,13 @@ public Set<SubscriptionData> subscriptions() {
}
@Override
- public void doRebalance() {
+ public synchronized void doRebalance() {
Review Comment:
Adding synchronized here introduces a lock-order inversion between
resetOffset() and shutdown(), which can deadlock when they run concurrently.
Could we avoid acquiring the consumer lock here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
