joeCarf commented on code in PR #7312:
URL: https://github.com/apache/rocketmq/pull/7312#discussion_r1325360835
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/DefaultGrpcMessingActivity.java:
##########
@@ -87,7 +87,7 @@ protected void init(MessagingProcessor messagingProcessor) {
this.routeActivity = new RouteActivity(messagingProcessor,
grpcClientSettingsManager, grpcChannelManager);
this.clientActivity = new ClientActivity(messagingProcessor,
grpcClientSettingsManager, grpcChannelManager);
- this.appendStartAndShutdown(this.grpcClientSettingsManager);
+ this.appendStartAndShutdown(this.grpcChannelManager);
Review Comment:
IMO, there is thread in grpcClientSettingsManager, it also need to be shut
down
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
