anguoming commented on code in PR #51: URL: https://github.com/apache/rocketmq-operator/pull/51#discussion_r1596190384
########## example/rocketmq_v1alpha1_rocketmq_exporter_cluster.yaml: ########## @@ -0,0 +1,157 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +apiVersion: v1 +kind: ConfigMap +metadata: + name: broker-config +data: + # BROKER_MEM sets the broker JVM, if set to "" then Xms = Xmx = max(min(1/2 ram, 1024MB), min(1/4 ram, 8GB)) + BROKER_MEM: " -Xms2g -Xmx2g -Xmn1g " + broker-common.conf: | + # brokerClusterName, brokerName, brokerId are automatically generated by the operator and do not set it manually!!! + deleteWhen=04 + fileReservedTime=48 + flushDiskType=ASYNC_FLUSH + # set brokerRole to ASYNC_MASTER or SYNC_MASTER. DO NOT set to SLAVE because the replica instance will automatically be set!!! + brokerRole=ASYNC_MASTER + +--- +apiVersion: rocketmq.apache.org/v1alpha1 +kind: Broker +metadata: + # name of broker cluster + name: broker +spec: + # size is the number of the broker cluster, each broker cluster contains a master broker and [replicaPerGroup] replica brokers. + size: 1 + # nameServers is the [ip:port] list of name service + nameServers: "" + # replicaPerGroup is the number of each broker cluster + replicaPerGroup: 0 + # brokerImage is the customized docker image repo of the RocketMQ broker + brokerImage: apacherocketmq/rocketmq-broker:4.5.0-alpine-operator-0.3.0 + # imagePullPolicy is the image pull policy + imagePullPolicy: Always + # resources describes the compute resource requirements and limits + resources: + requests: + memory: "2048Mi" + cpu: "250m" + limits: + memory: "12288Mi" + cpu: "500m" + # allowRestart defines whether allow pod restart + allowRestart: true + # storageMode can be EmptyDir, HostPath, StorageClass + storageMode: EmptyDir + # hostPath is the local path to store data + hostPath: /tmp/data/rocketmq/broker + # scalePodName is [Broker name]-[broker group number]-master-0 + scalePodName: broker-0-master-0 + # env defines custom env, e.g. BROKER_MEM + env: + - name: BROKER_MEM + valueFrom: + configMapKeyRef: + name: broker-config + key: BROKER_MEM + # volumes defines the broker.conf + volumes: + - name: broker-config + configMap: + name: broker-config + items: + - key: broker-common.conf + path: broker-common.conf + # volumeClaimTemplates defines the storageClass + volumeClaimTemplates: + - metadata: + name: broker-storage + spec: + accessModes: + - ReadWriteOnce + resources: + requests: + storage: 8Gi + selector: + matchLabels: + app: broker-storage-pv +--- +apiVersion: rocketmq.apache.org/v1alpha1 +kind: NameService +metadata: + name: name-service +spec: + # size is the the name service instance number of the name service cluster + size: 1 + # nameServiceImage is the customized docker image repo of the RocketMQ name service + nameServiceImage: apacherocketmq/rocketmq-nameserver:4.5.0-alpine-operator-0.3.0 + # imagePullPolicy is the image pull policy + imagePullPolicy: Always + # hostNetwork can be true or false + hostNetwork: true + # Set DNS policy for the pod. + # Defaults to "ClusterFirst". + # Valid values are 'ClusterFirstWithHostNet', 'ClusterFirst', 'Default' or 'None'. + # DNS parameters given in DNSConfig will be merged with the policy selected with DNSPolicy. + # To have DNS options set along with hostNetwork, you have to specify DNS policy + # explicitly to 'ClusterFirstWithHostNet'. + dnsPolicy: ClusterFirstWithHostNet + # resources describes the compute resource requirements and limits + resources: + requests: + memory: "512Mi" + cpu: "250m" + limits: + memory: "1024Mi" + cpu: "500m" + # storageMode can be EmptyDir, HostPath, StorageClass + storageMode: EmptyDir + # hostPath is the local path to store data + hostPath: /data/rocketmq/nameserver + exporter: + enabled: true + annotations: + prometheus.io/path: /metrics + prometheus.io/port: "5557" + prometheus.io/scrape: "true" + env: + - name: WEB_TELEMETRY_PATH + value: /metrics + - name: ROCKETMQ_VERSION + value: V4_3_2 + - name: NAMESRV_ADDR + value: 127.0.0.1:9876 Review Comment: I think it better to init the NAMESRV_ADDR env in nameservice_controller.go -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
