RapperCL opened a new issue, #8201:
URL: https://github.com/apache/rocketmq/issues/8201

   ### Before Creating the Enhancement Request
   
   - [X] I have confirmed that this should be classified as an enhancement 
rather than a bug/feature.
   
   
   ### Summary
   
   path:
   org.apache.rocketmq.store.timer.TimerMessageStore#splitIntoLists
   
![image](https://github.com/apache/rocketmq/assets/44110731/ebe651f7-1dbc-475a-b8ba-9bc39fb7afcf)
   The splitting strategy mainly considers the dimension of commitLog and 
ensures that the maximum number of messages does not exceed 2000, but the above 
implementation is somewhat messy.
   Optimize: 
   Considering the emptiness, simplifying the logic by splitting it apart
   
   
   ### Motivation
   
   1. By considering scenarios where data is empty, we can reduce ineffective 
executions.
   2. By simplifying the current splitting logic, we can improve readability 
and maintainability.
   
   ### Describe the Solution You'd Like
   
   Considering the emptiness, simplifying the logic by splitting it apart
   
   ### Describe Alternatives You've Considered
   
   no
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to