Re: [PR] [ISSUE #8334] fix: irreducible reference count of mapped file caused by held tiered storage's dispatch [rocketmq]

[via GitHub]

lizhimins commented on code in PR #8335:
URL: https://github.com/apache/rocketmq/pull/8335#discussion_r1663407726


##########
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/core/MessageStoreDispatcherImpl.java:
##########
@@ -233,8 +242,10 @@ public CompletableFuture<Boolean> 
doScheduleDispatch(FlatFileInterface flatFile,
 
                 result = flatFile.appendConsumeQueue(dispatchRequest);
                 if (!AppendResult.SUCCESS.equals(result)) {
+                    message.release();
                     break;
                 }
+                flatFile.addMessage(message);

Review Comment:
   227 行，append CommitLog 的时候会有 this.bufferResultList.add(message); 这里是重复了吗？
   
   正常会在 MessageStoreDispatcherImpl#commitAsync 这里释放引用



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org