caigy commented on code in PR #9148:
URL: https://github.com/apache/rocketmq/pull/9148#discussion_r1922967827
##########
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java:
##########
@@ -773,14 +773,6 @@ private void checkConfig() throws MQClientException {
// check consumerGroup
Validators.checkGroup(this.defaultMQPullConsumer.getConsumerGroup());
- // consumerGroup
- if (null == this.defaultMQPullConsumer.getConsumerGroup()) {
- throw new MQClientException(
- "consumerGroup is null"
- + FAQUrl.suggestTodo(FAQUrl.CLIENT_PARAMETER_CHECK_URL),
- null);
Review Comment:
IMO exception thrown in `Validators.checkGroup` should keep this more
detailed error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
