This is an automated email from the ASF dual-hosted git repository.

lizhimin pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new 577371e208 [ISSUE #9352] Fix wrong value in topic-group cache (#9424)
577371e208 is described below

commit 577371e2082922c4383a7994f2749f3b18ac1429
Author: yangguodong <[email protected]>
AuthorDate: Fri May 30 14:09:26 2025 +0800

    [ISSUE #9352] Fix wrong value in topic-group cache (#9424)
---
 .../main/java/org/apache/rocketmq/broker/client/ConsumerManager.java    | 2 +-
 .../java/org/apache/rocketmq/broker/client/ConsumerManagerTest.java     | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git 
a/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerManager.java 
b/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerManager.java
index 04238e2c30..5aec8e577f 100644
--- 
a/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerManager.java
+++ 
b/broker/src/main/java/org/apache/rocketmq/broker/client/ConsumerManager.java
@@ -241,7 +241,7 @@ public class ConsumerManager {
                 Set<String> prev = 
this.topicGroupTable.putIfAbsent(subscriptionData.getTopic(), tmp);
                 groups = prev != null ? prev : tmp;
             }
-            groups.add(subscriptionData.getTopic());
+            groups.add(group);
         }
 
         boolean r1 =
diff --git 
a/broker/src/test/java/org/apache/rocketmq/broker/client/ConsumerManagerTest.java
 
b/broker/src/test/java/org/apache/rocketmq/broker/client/ConsumerManagerTest.java
index a23ad20037..2afd071b5e 100644
--- 
a/broker/src/test/java/org/apache/rocketmq/broker/client/ConsumerManagerTest.java
+++ 
b/broker/src/test/java/org/apache/rocketmq/broker/client/ConsumerManagerTest.java
@@ -17,6 +17,7 @@
 
 package org.apache.rocketmq.broker.client;
 
+import com.google.common.collect.ImmutableSet;
 import io.netty.channel.Channel;
 import org.apache.rocketmq.broker.BrokerController;
 import org.apache.rocketmq.broker.filter.ConsumerFilterManager;
@@ -179,6 +180,7 @@ public class ConsumerManagerTest {
         register();
         final HashSet<String> consumeGroup = 
consumerManager.queryTopicConsumeByWho(TOPIC);
         assertFalse(consumeGroup.isEmpty());
+        
assertThat(consumerManager.queryTopicConsumeByWho(TOPIC)).isEqualTo(ImmutableSet.of(GROUP));
     }
 
     @Test

Reply via email to