xiaoyifang commented on code in PR #9505:
URL: https://github.com/apache/rocketmq/pull/9505#discussion_r2184874168
##########
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyDecoder.java:
##########
@@ -49,7 +49,7 @@ public Object decode(ChannelHandlerContext ctx, ByteBuf in)
throws Exception {
cmd.setProcessTimer(timer);
return cmd;
} catch (Exception e) {
- log.error("decode exception, " +
RemotingHelper.parseChannelRemoteAddr(ctx.channel()), e);
+ log.error("decode exception, remoteAddress: {}"
,RemotingHelper.parseChannelRemoteAddr(ctx.channel()), e);
Review Comment:
IMO， `log.error(String,object,object)` ,the third exception will be
treated as object which is not intended .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
