guyinyou opened a new pull request, #9731: URL: https://github.com/apache/rocketmq/pull/9731
These two configurations are typically used together and need to be enabled/disabled simultaneously, so merging them simplifies configuration management. Changes: - Remove enableRunningFlagsInFlush configuration field and its getter/setter methods - Update AllocateMappedFileService to use isWriteWithoutMmap for runningFlags logic - Update CommitLog to use isWriteWithoutMmap for runningFlags logic - Update writeWithoutMmap documentation to explain runningFlags behavior Behavior after merge: - When isWriteWithoutMmap=true: Use RandomAccessFile + set runningFlags to null - When isWriteWithoutMmap=false: Use MappedByteBuffer + use normal runningFlags This eliminates the need to manage two separate but related configurations, reducing the chance of misconfiguration and simplifying the codebase. Change-Id: I053a6ee5c8ba9be825db47940900ce01a8c707b9 <!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. --> ### Which Issue(s) This PR Fixes <!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. --> Fixes #9730 ### Brief Description <!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. --> ### How Did You Test This Change? <!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
