lizhimins commented on code in PR #9774:
URL: https://github.com/apache/rocketmq/pull/9774#discussion_r2450587570


##########
broker/src/main/java/org/apache/rocketmq/broker/config/v1/RocksDBConsumerOffsetManager.java:
##########
@@ -112,19 +137,26 @@ protected void decodeOffset(final byte[] key, final 
byte[] body) {
         log.info("load exist local offset, {}, {}", topicAtGroup, 
wrapper.getOffsetTable());
     }
 
-    public String rocksdbConfigFilePath() {
-        return 
this.brokerController.getMessageStoreConfig().getStorePathRootDir() + 
File.separator + "config" + File.separator + "consumerOffsets" + File.separator;
+    public String rocksdbConfigFilePath(String storePathRootDir, boolean 
useSingleRocksDBForAllConfigs) {
+        if (StringUtils.isBlank(storePathRootDir)) {
+            storePathRootDir = 
brokerController.getMessageStoreConfig().getStorePathRootDir();
+        }
+        if (useSingleRocksDBForAllConfigs) {
+            return storePathRootDir + java.io.File.separator + "config" + 
java.io.File.separator + "metadata" + java.io.File.separator;

Review Comment:
   Paths.get



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to