qianye1001 commented on code in PR #10012:
URL: https://github.com/apache/rocketmq/pull/10012#discussion_r2697087358
##########
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java:
##########
@@ -378,6 +381,21 @@ private void recover(final boolean lastExitOK) throws
RocksDBException {
// recover commitlog
long dispatchFromPhyOffset =
this.consumeQueueStore.getDispatchFromPhyOffset();
+
Review Comment:
Consider defining the store that requires commitlog dispatch and recovery as
an interface. Each store will register itself in the commitlog when loading.
Such an abstraction is more reasonable than changing the commitlog recover
process when add one new store.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
