oss-taishan-ai commented on issue #10425: URL: https://github.com/apache/rocketmq/issues/10425#issuecomment-4619912442
**Issue Evaluation** Category: `type/bug` | Status: **Confirmed** The reported issue has been verified against the current codebase. **Root Cause:** PR #9521 removed the `DataVersion.nextVersion()` call from `TopicConfigManager#buildSerializeWrapper` when `enableSplitRegistration` is enabled. During split broker registration, the broker sends topic configs in multiple batches. The NameServer's `RouteInfoManager` uses `DataVersion` comparison (`isBrokerTopicConfigChanged`) to decide whether topic route data needs updating. After the first batch is processed and its `DataVersion` is stored in `brokerLiveTable`, subsequent batches carrying the **same** `DataVersion` are treated as unchanged — causing topic config updates in later batches to be skipped for existing topics. **Impact:** NameServer route data may not reflect topic config updates for topics that fall outside the first split registration batch. This is a data consistency issue between broker and name server. **Severity:** High **Affected code path:** - `RouteInfoManager#registerBroker` → `isBrokerTopicConfigChanged` (line ~352) compares `DataVersion` from each split batch against stored value - `isTopicConfigChanged` (line ~447) relies on the same comparison, so existing topics in later batches get skipped PR #10426 correctly restores the `DataVersion` advancement and adds a regression test. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
