guyinyou opened a new pull request, #1267:
URL: https://github.com/apache/rocketmq-clients/pull/1267
Both methods in ProcessQueue.cs had a fall-through bug where the
InvalidReceiptHandle branch called tcs.SetException() but did not return,
causing execution to continue into the subsequent 'if (statusCode != Code.Ok)'
block. This resulted in an unnecessary call to AckMessageLater /
ChangeInvisibleDurationLater with an already-faulted TaskCompletionSource,
which would throw an InvalidOperationException at runtime.
Add the missing 'return;' statements to match the behavior of the Java
reference implementation, where each non-success branch explicitly returns
after resolving the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
