The GitHub Actions job "Golang Coverage" on rocketmq-clients.git/master has 
failed.
Run started by GitHub user RongtongJin (triggered by RongtongJin).

Head commit for run:
061dd5031be452f229cf69612eb5af0b962b5337 / guyinyou 
<[email protected]>
[C#] Fix missing return after InvalidReceiptHandle in AckMessage and 
ChangeInvisibleDuration (#1267)

Both methods in ProcessQueue.cs had a fall-through bug where the
InvalidReceiptHandle branch called tcs.SetException() but did not return,
causing execution to continue into the subsequent 'if (statusCode != Code.Ok)'
block. This resulted in an unnecessary call to AckMessageLater /
ChangeInvisibleDurationLater with an already-faulted TaskCompletionSource,
which would throw an InvalidOperationException at runtime.

Add the missing 'return;' statements to match the behavior of the Java
reference implementation, where each non-success branch explicitly returns
after resolving the future.

Co-authored-by: guyinyou <[email protected]>

Report URL: https://github.com/apache/rocketmq-clients/actions/runs/27331555836

With regards,
GitHub Actions via GitBox

Reply via email to