guyinyou opened a new pull request, #1269:
URL: https://github.com/apache/rocketmq-clients/pull/1269
## Summary
- The `messageHookPointsStatus` in three Ack/DLQ hook locations was
incorrectly initialized to `ERROR` and set to `OK` when the response code was
not `Code_OK` — the exact opposite of the intended behavior.
- Fixed by initializing to `OK` and switching to `ERROR` on failure,
consistent with the pattern used in `changeInvisibleDuration0`.
- Affected locations:
- `push_consumer.go`: `Ack()` and `ForwardMessageToDeadLetterQueue()`
- `simple_consumer.go`: `Ack()`
## Test plan
- [ ] Verify `doAfter` receives `ERROR` status when `err != nil`
- [ ] Verify `doAfter` receives `ERROR` status when
`resp.GetStatus().GetCode() != Code_OK`
- [ ] Verify `doAfter` receives `OK` status on successful responses
- [ ] Run existing unit tests for the Go SDK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
