The GitHub Actions job "Build" on 
rocketmq-clients.git/fix/transaction-commit-rollback-error has succeeded.
Run started by GitHub user guyinyou (triggered by guyinyou).

Head commit for run:
83af1431d910fe5cf8f1c65eade3553538828d0d / guyinyou 
<[email protected]>
[Go] Fix Commit/RollBack always returning nil in transaction

The Commit() and RollBack() methods in transactionImpl silently swallowed
errors from endTransaction: errors were only logged inside the Range
callback, and the caller always received nil, making it impossible to
detect a failed commit or rollback.

What changed:
- Capture the error from the Range closure and return it to the caller.
- Stop Range iteration on first error (matching Java's fail-fast behavior).
- Return an error when messageSendReceiptMap is empty, aligning with the
  Java client's IllegalStateException ("Transactional message has not been
  sent yet").

Affected: golang/transaction.go Commit(), RollBack()

Report URL: https://github.com/apache/rocketmq-clients/actions/runs/27338485962

With regards,
GitHub Actions via GitBox

Reply via email to