The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git/fix-bitsarray-off-by-one has failed. Run started by GitHub user SummCoder (triggered by ShannonDing).
Head commit for run: 7c00be2d1f7d49434963bda2a1569e7223041c1a / SummCoder <[email protected]> Fix off-by-one in BitsArray boundary checks and add unit tests **Bug fix** checkBytePosition and checkBitPosition used '>' instead of '>=', allowing positions equal to array length to pass validation and cause ArrayIndexOutOfBoundsException instead of the intended IllegalArgumentException. **Production impact if not fixed** Minimal. getByte/setByte are only called internally by xor/or/and with safe bounds. getBit/setBit positions come from BloomFilterData hash functions which always produce in-range values. The incorrect check has no known production trigger. **Impact of fix** Zero negative impact. All valid positions (0 to length-1) unchanged. Edge case now correctly throws IllegalArgumentException instead of ArrayIndexOutOfBoundsException. **Tests added** - BitsArrayTest: 27 tests covering create, bit/byte ops, boundary, including regression tests for the fixed checks - PlainAccessConfigTest: 12 tests for getters/setters, equals/hashCode References #8262 Report URL: https://github.com/apache/rocketmq/actions/runs/27461645607 With regards, GitHub Actions via GitBox
