RockteMQ-AI commented on issue #10541: URL: https://github.com/apache/rocketmq/issues/10541#issuecomment-4768580968
**Issue Evaluation** Category: `type/bug` | Status: **Confirmed** The reported issue has been verified against the current codebase (`develop` branch). **Root Cause:** `ConsumerGroupInfo.updateSubscription()` compares only `subVersion` (a timestamp) to decide whether to log "subscription changed". Since `FilterAPI.build()` creates a new `SubscriptionData` with `subVersion = System.currentTimeMillis()` on every rebuild, the log fires even when the actual subscription content (topic, filter expression, tags) is identical. The trigger path is `ClientActivity.processAndClientSettings()` (telemetry/settings path, `updateSubscription = true`), not the heartbeat path itself. **Evidence:** | Claim | File | Line | |-------|------|------| | `registerConsumer()` rebuilds subscriptions each call | `proxy/.../ClientActivity.java` | :122, :443 | | `FilterAPI.build()` sets `subVersion = currentTimeMillis()` | `remoting/.../filter/FilterAPI.java` | :67; `SubscriptionData.java` :36 | | `updateSubscription()` logs on `subVersion` comparison only | `broker/.../ConsumerGroupInfo.java` | :187-193 | | No content comparison before logging | `broker/.../ConsumerGroupInfo.java` | :187 | **Impact:** Log noise for stable gRPC consumers. Functional behavior is not affected (`updateSubscription()` returns `updated = false` for version-only changes). **Severity:** Low **Suggested Fix:** In `ConsumerGroupInfo.updateSubscription()`, compare actual subscription content (`topic`, `subString`, `expressionType`, `tagsSet`, `codeSet`) before logging "subscription changed" and replacing the stored entry. Only emit the log and update when content actually differs. An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
