salmaloel657-dotcom commented on issue #10538: URL: https://github.com/apache/rocketmq/issues/10538#issuecomment-4778292222
I agree with the assessment regarding ISSUE #10538. Since FastCodesHeader now allows SendMessageRequestHeader to encode V2 directly, eliminating the SendMessageRequestHeaderV2 intermediate object is a logical step to reduce overhead. The suggested approach to add V2-compatible methods to SendMessageRequestHeader and update the client-side send paths while deprecating the old header seems sound. I will begin looking into the implementation in MQClientAPIImpl and SendMessageRequestHeader. On Mon, Jun 22, 2026, 5:03 AM RockteMQ-AI ***@***.***> wrote: > *RockteMQ-AI* left a comment (apache/rocketmq#10538) > <https://github.com/apache/rocketmq/issues/10538#issuecomment-4767117485> > > *Issue Evaluation* > > Category: type/enhancement | Status: *Evaluated* > > *Feasibility:* Feasible > *Scope:* client module (MQClientAPIImpl, DefaultMQProducerImpl), remoting > module (SendMessageRequestHeader, SendMessageRequestHeaderV2) > *Compatibility:* Low risk — V2 header encoding is internal to the > remoting protocol; wire format remains unchanged. > > The analysis is correct. SendMessageRequestHeaderV2 currently acts as an > intermediate object with 14 short-named fields (a–n) that are copied from > SendMessageRequestHeader on every send. With FastCodesHeader support in > SendMessageRequestHeader (#10535 > <https://github.com/apache/rocketmq/pull/10535>), the V1 header can > directly produce the V2 wire format, eliminating the per-request object > allocation and field-copy overhead. > > *Suggested approach:* > > 1. Add V2-compatible encode(ByteBuf) / decode(ByteBuf) methods to > SendMessageRequestHeader that use the short field names. > 2. Update client-side send paths (MQClientAPIImpl.sendMessage) to use > SendMessageRequestHeader directly with the V2 request code. > 3. Deprecate (not remove) SendMessageRequestHeaderV2 to maintain > backward compatibility for any external consumers. > > ------------------------------ > > *Automated evaluation by RockteMQ-AI* > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/rocketmq/issues/10538?email_source=notifications&email_token=CABFFMOR3Q5QO2WW7AW4X5L5BD763A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZWG4YTCNZUHA22M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#issuecomment-4767117485>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/CABFFMMO5RNVCUJPDU2C4WD5BD763AVCNFSNUABEKJSXA33TNF2G64TZHM3TKMJWGQ4DEMZ3JFZXG5LFHM2DOMJVGUYDCNRUG6QXMAQ> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/CABFFMODECPEJT5ID6Y6ANT5BD763A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZWG4YTCNZUHA22M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ> > and Android > <https://github.com/notifications/mobile/android/CABFFMPFTCLSXJMHFPV6AQ35BD763A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZWG4YTCNZUHA22M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>. > Download it today! > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
