wang-jiahua commented on PR #10536: URL: https://github.com/apache/rocketmq/pull/10536#issuecomment-4785548798
Closing this PR. After review, the actual changes (primitive long setter overloads) do not provide meaningful performance optimization. The FastCodesHeader encode/decode methods already exist in develop for PullMessageRequestHeader/ResponseHeader. The original optimization (Long→long field type change) was reverted due to wire format concerns, leaving only unused setter overloads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
