f1amingo opened a new issue, #10560:
URL: https://github.com/apache/rocketmq/issues/10560

   ### Before Creating the Enhancement Request
   - [x] I have confirmed this should be classified as an enhancement.
   
   ### Summary
   Remove the `enableLiteEventMode` boolean switch from `BrokerConfig` since it 
defaults to `true` and is never intended to be disabled in production.
   
   ### Motivation
   The `enableLiteEventMode` flag was introduced as a guard for the lite event 
dispatch feature, but it has always defaulted to `true`. The disabled path 
(non-event-mode fallback in `getEventIterator`, early-returns in 
`dispatch`/`doDispatch`/`selectAndDispatch`/`doFullDispatchForClient`/`doFullDispatchForWildcardGroup`)
 is dead code that adds cognitive overhead and maintenance burden. Removing it 
simplifies the codebase and reduces branch complexity.
   
   ### Describe the Solution You Would Like
   1. Remove `enableLiteEventMode` field, getter, and setter from `BrokerConfig`
   2. Remove all `isEnableLiteEventMode()` guard checks in 
`LiteEventDispatcher` (5 early-returns) and `PopLiteMessageProcessor` (1 
condition)
   3. Simplify `getEventIterator` to always use the event-set path
   4. Delete the now-unused `LiteSubscriptionIterator` inner class
   5. Remove corresponding test cases that cover the disabled-mode branches
   6. Clean up stale Javadoc references to "event mode" toggle
   
   ### Describe Alternatives You Have Considered
   Keeping the switch for potential future rollback — rejected as the non-event 
path was never exercised and reintroducing it via git history is trivial if 
needed.
   
   ### Additional Context
   N/A


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to