RockteMQ-AI commented on PR #10561: URL: https://github.com/apache/rocketmq/pull/10561#issuecomment-4844045694
## Review by github-manager-bot ### Summary Removes the `enableLiteEventMode` config switch from `BrokerConfig` and all associated dead code paths. Since the field always defaults to `true`, the disabled-mode branches are unreachable, making this a safe cleanup. ### Findings - **[Info]** `BrokerConfig.java` — After removing the field, two consecutive blank lines remain (before `liteEventCheckInterval` and after `setUseSeparateRetryQueue`). Minor cosmetic; consider cleaning up. - **[Info]** `PopLiteMessageProcessorTest.java` — The `liteLifecycleManager` mock field declaration may still exist even though the `when(...)` setup was removed. If it is truly unused now, consider removing the field declaration too to avoid confusion. - **[Info]** `LiteEventDispatcher.java` — The simplified `getEventIterator` is clean. Good removal of the `LiteSubscriptionIterator` inner class and the `Collections` import. ### Suggestions No blocking concerns. The change is consistent: all 5 guard checks, the dead `LiteSubscriptionIterator` class, the disabled-mode branch in `getEventIterator`, the dead condition in `PopLiteMessageProcessor.popLiteTopic`, and the corresponding test cases are all properly removed together. ### Verdict Straightforward dead-code removal. Looks good. --- *Automated review by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
