RockteMQ-AI commented on issue #10562: URL: https://github.com/apache/rocketmq/issues/10562#issuecomment-4850141201
**Issue Evaluation** Category: `type/enhancement` | Status: **Confirmed** The analysis is correct. The current `transferToFsStoreTest` calls `consumerService.start()` / `consumerService.shutdown()`, which starts the revive thread and `PopConsumerCache` cleanup thread unnecessarily. Since `transferToFsStore()` is a synchronous operation that only requires the RocksDB store to be initialized, the full service lifecycle is not needed. Other tests in the same file (`ackAsyncTest`, `reviveRetryTest`, `reviveBackoffRetryTest`) already follow the pattern of using `consumerService.getPopConsumerStore().start()` / `consumerService.getPopConsumerStore().shutdown()` — this change aligns `transferToFsStoreTest` with that convention. **Proposed change:** Replace `consumerService.start()` with `consumerService.getPopConsumerStore().start()` (and similarly for shutdown). **Impact:** Test execution time ~60s → ~1.3s, same assertions and pass/fail behavior. An automated fix proposal can be generated if needed. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
