itxaiohanglover opened a new pull request, #10595:
URL: https://github.com/apache/rocketmq/pull/10595

   ## What is the purpose of the change
   
   Fixes apache/rocketmq-dashboard#380
   
   In `DefaultMQAdminExtImpl.consumed()` and `consumedConcurrent()`, the 
consumer offset comparison used strict `>` instead of `>=`. When the consumer 
offset exactly matched the message's queue offset, the message was incorrectly 
reported as `NOT_CONSUME_YET` instead of `CONSUMED`.
   
   ## Brief changelog
   
   - Changed `>` to `>=` in `consumed()` method
   - Changed `>` to `>=` in `consumedConcurrent()` method
   - Added test `testConsumedWithEqualOffset` verifying the fix
   
   ## Verifying this change
   
   Added test case `testConsumedWithEqualOffset` that sets consumerOffset equal 
to the message's queueOffset and verifies `consumed()` returns true.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to