RockteMQ-AI commented on PR #10631:
URL: https://github.com/apache/rocketmq/pull/10631#issuecomment-5025794442
## Correction to previous review
@somak2kai Apologies for the confusion — the previous review incorrectly
flagged a compilation error regarding `updateAssignQueueAndStartPullTask`.
After re-checking, this method **does exist** in the codebase as a public
method at `DefaultLitePullConsumerImpl.java:243`:
```java
public void updateAssignQueueAndStartPullTask(String topic,
Set<MessageQueue> mqAll, Set<MessageQueue> mqDivided) {
```
The test calling `consumer.updateAssignQueueAndStartPullTask(topic,
Collections.emptySet(), mqDivided)` will compile and run correctly. **There is
no compilation error.**
The rest of the review findings remain valid:
- ✅ The `synchronized(taskTable)` approach correctly addresses the data race
- ✅ All three mutation paths are consistently synchronized
- 💡 The suggestion to use a dedicated lock object is optional style
preference
Sorry for the false alarm on the critical finding.
---
*Correction by github-manager-bot*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
