zhaohai666 opened a new issue, #10637:
URL: https://github.com/apache/rocketmq/issues/10637
### Before Creating the Enhancement Request
- [x] I have confirmed that this should be classified as an enhancement
rather than a bug/feature.
### Summary
# [studio] feat: Admin Service Integration with Messaging Pipeline and E2E
Tests
## Background
This is the sixth and final atomic PR in the RIP-2 (Proxy Admin Interface)
series. It integrates the admin service with the existing messaging pipeline
(receipt handle management, channel tracking, message processing) and provides
end-to-end integration tests.
## Design Proposal
### Receipt Handle Management
- **ReceiptHandleManager** (interface): Admin-facing API for receipt handle
lifecycle queries and operations
- **DefaultReceiptHandleManager**: Implementation that wraps the existing
receipt handle processor, adding admin-specific query capabilities (list by
group, list by topic, TTL inspection)
### Messaging Pipeline Integration
- **GrpcMessagingActivity / DefaultGrpcMessagingActivity**: Extended to
expose client activity metrics to the admin service (message count, error rate,
last operation timestamp)
- **GrpcMessagingApplication**: Modified to register the admin service as an
observer of messaging lifecycle events
- **GrpcChannelManager / GrpcClientChannel**: Extended with admin query
methods — channel state inspection, pending request count, connection metadata
- **ClientActivity**: Enhanced to track per-client operation history for
admin diagnostics
### Processor Extension
- **MessagingProcessor / DefaultMessagingProcessor**: Added admin query
methods that aggregate broker-side state (topic config, subscription info) for
the admin API
- **ReceiptHandleProcessor**: Extended to support admin-initiated handle
inspection and forced expiration
### Infrastructure
- **WORKSPACE**: Updated Bazel workspace for integration test dependencies
- **SimpleChannel**: Minor fix for admin channel state reporting
### End-to-End Integration Test
- **ProxyAdminGrpcIT** (602 lines): Full-stack integration test that:
1. Starts a real Proxy instance with admin service enabled
2. Connects a gRPC admin client
3. Verifies all admin RPCs (ListClients, GetTopicRoute, WatchRouteChange,
etc.)
4. Tests authentication flow (valid/invalid tokens)
5. Validates streaming route change notifications
## Scope
| File | Type | Description |
|------|------|-------------|
| `ReceiptHandleManager.java` | New | Handle management interface |
| `DefaultReceiptHandleManager.java` | New | Handle management
implementation |
| `SimpleChannel.java` | Modified | Admin channel state fix |
| `DefaultGrpcMessagingActivity.java` | Modified | Admin metrics exposure |
| `GrpcMessagingActivity.java` | Modified | Interface extension |
| `GrpcMessagingApplication.java` | Modified | Admin observer registration |
| `GrpcChannelManager.java` | Modified | Admin query methods |
| `GrpcClientChannel.java` | Modified | Channel metadata for admin |
| `ClientActivity.java` | Modified | Operation history tracking |
| `DefaultMessagingProcessor.java` | Modified | Admin query aggregation |
| `MessagingProcessor.java` | Modified | Interface extension |
| `ReceiptHandleProcessor.java` | Modified | Admin handle inspection |
| `WORKSPACE` | Modified | Integration test dependencies |
| `AbstractRemotingActivityTest.java` | New | Remoting activity tests |
| `ProxyAdminGrpcIT.java` | New | E2E integration test (602 lines) |
**Total: 15 files, +1291 lines**
## Dependencies
- Depends on all previous PRs (#1–#5)
- This is the final integration PR that completes the RIP-2 implementation
## Testing
- E2E integration test covering all admin RPCs against a real Proxy instance
- Authentication flow verification (token-based and ACL-based)
- Streaming test for route change notifications
- Remoting activity unit tests
## Branch
`feature/rip-2-pr6-messaging-integration`
### Motivation
# [studio] feat: Admin Service Integration with Messaging Pipeline and E2E
Tests
## Background
This is the sixth and final atomic PR in the RIP-2 (Proxy Admin Interface)
series. It integrates the admin service with the existing messaging pipeline
(receipt handle management, channel tracking, message processing) and provides
end-to-end integration tests.
## Design Proposal
### Receipt Handle Management
- **ReceiptHandleManager** (interface): Admin-facing API for receipt handle
lifecycle queries and operations
- **DefaultReceiptHandleManager**: Implementation that wraps the existing
receipt handle processor, adding admin-specific query capabilities (list by
group, list by topic, TTL inspection)
### Messaging Pipeline Integration
- **GrpcMessagingActivity / DefaultGrpcMessagingActivity**: Extended to
expose client activity metrics to the admin service (message count, error rate,
last operation timestamp)
- **GrpcMessagingApplication**: Modified to register the admin service as an
observer of messaging lifecycle events
- **GrpcChannelManager / GrpcClientChannel**: Extended with admin query
methods — channel state inspection, pending request count, connection metadata
- **ClientActivity**: Enhanced to track per-client operation history for
admin diagnostics
### Processor Extension
- **MessagingProcessor / DefaultMessagingProcessor**: Added admin query
methods that aggregate broker-side state (topic config, subscription info) for
the admin API
- **ReceiptHandleProcessor**: Extended to support admin-initiated handle
inspection and forced expiration
### Infrastructure
- **WORKSPACE**: Updated Bazel workspace for integration test dependencies
- **SimpleChannel**: Minor fix for admin channel state reporting
### End-to-End Integration Test
- **ProxyAdminGrpcIT** (602 lines): Full-stack integration test that:
1. Starts a real Proxy instance with admin service enabled
2. Connects a gRPC admin client
3. Verifies all admin RPCs (ListClients, GetTopicRoute, WatchRouteChange,
etc.)
4. Tests authentication flow (valid/invalid tokens)
5. Validates streaming route change notifications
## Scope
| File | Type | Description |
|------|------|-------------|
| `ReceiptHandleManager.java` | New | Handle management interface |
| `DefaultReceiptHandleManager.java` | New | Handle management
implementation |
| `SimpleChannel.java` | Modified | Admin channel state fix |
| `DefaultGrpcMessagingActivity.java` | Modified | Admin metrics exposure |
| `GrpcMessagingActivity.java` | Modified | Interface extension |
| `GrpcMessagingApplication.java` | Modified | Admin observer registration |
| `GrpcChannelManager.java` | Modified | Admin query methods |
| `GrpcClientChannel.java` | Modified | Channel metadata for admin |
| `ClientActivity.java` | Modified | Operation history tracking |
| `DefaultMessagingProcessor.java` | Modified | Admin query aggregation |
| `MessagingProcessor.java` | Modified | Interface extension |
| `ReceiptHandleProcessor.java` | Modified | Admin handle inspection |
| `WORKSPACE` | Modified | Integration test dependencies |
| `AbstractRemotingActivityTest.java` | New | Remoting activity tests |
| `ProxyAdminGrpcIT.java` | New | E2E integration test (602 lines) |
**Total: 15 files, +1291 lines**
## Dependencies
- Depends on all previous PRs (#1–#5)
- This is the final integration PR that completes the RIP-2 implementation
## Testing
- E2E integration test covering all admin RPCs against a real Proxy instance
- Authentication flow verification (token-based and ACL-based)
- Streaming test for route change notifications
- Remoting activity unit tests
## Branch
`feature/rip-2-pr6-messaging-integration`
### Describe the Solution You'd Like
# [studio] feat: Admin Service Integration with Messaging Pipeline and E2E
Tests
## Background
This is the sixth and final atomic PR in the RIP-2 (Proxy Admin Interface)
series. It integrates the admin service with the existing messaging pipeline
(receipt handle management, channel tracking, message processing) and provides
end-to-end integration tests.
## Design Proposal
### Receipt Handle Management
- **ReceiptHandleManager** (interface): Admin-facing API for receipt handle
lifecycle queries and operations
- **DefaultReceiptHandleManager**: Implementation that wraps the existing
receipt handle processor, adding admin-specific query capabilities (list by
group, list by topic, TTL inspection)
### Messaging Pipeline Integration
- **GrpcMessagingActivity / DefaultGrpcMessagingActivity**: Extended to
expose client activity metrics to the admin service (message count, error rate,
last operation timestamp)
- **GrpcMessagingApplication**: Modified to register the admin service as an
observer of messaging lifecycle events
- **GrpcChannelManager / GrpcClientChannel**: Extended with admin query
methods — channel state inspection, pending request count, connection metadata
- **ClientActivity**: Enhanced to track per-client operation history for
admin diagnostics
### Processor Extension
- **MessagingProcessor / DefaultMessagingProcessor**: Added admin query
methods that aggregate broker-side state (topic config, subscription info) for
the admin API
- **ReceiptHandleProcessor**: Extended to support admin-initiated handle
inspection and forced expiration
### Infrastructure
- **WORKSPACE**: Updated Bazel workspace for integration test dependencies
- **SimpleChannel**: Minor fix for admin channel state reporting
### End-to-End Integration Test
- **ProxyAdminGrpcIT** (602 lines): Full-stack integration test that:
1. Starts a real Proxy instance with admin service enabled
2. Connects a gRPC admin client
3. Verifies all admin RPCs (ListClients, GetTopicRoute, WatchRouteChange,
etc.)
4. Tests authentication flow (valid/invalid tokens)
5. Validates streaming route change notifications
## Scope
| File | Type | Description |
|------|------|-------------|
| `ReceiptHandleManager.java` | New | Handle management interface |
| `DefaultReceiptHandleManager.java` | New | Handle management
implementation |
| `SimpleChannel.java` | Modified | Admin channel state fix |
| `DefaultGrpcMessagingActivity.java` | Modified | Admin metrics exposure |
| `GrpcMessagingActivity.java` | Modified | Interface extension |
| `GrpcMessagingApplication.java` | Modified | Admin observer registration |
| `GrpcChannelManager.java` | Modified | Admin query methods |
| `GrpcClientChannel.java` | Modified | Channel metadata for admin |
| `ClientActivity.java` | Modified | Operation history tracking |
| `DefaultMessagingProcessor.java` | Modified | Admin query aggregation |
| `MessagingProcessor.java` | Modified | Interface extension |
| `ReceiptHandleProcessor.java` | Modified | Admin handle inspection |
| `WORKSPACE` | Modified | Integration test dependencies |
| `AbstractRemotingActivityTest.java` | New | Remoting activity tests |
| `ProxyAdminGrpcIT.java` | New | E2E integration test (602 lines) |
**Total: 15 files, +1291 lines**
## Dependencies
- Depends on all previous PRs (#1–#5)
- This is the final integration PR that completes the RIP-2 implementation
## Testing
- E2E integration test covering all admin RPCs against a real Proxy instance
- Authentication flow verification (token-based and ACL-based)
- Streaming test for route change notifications
- Remoting activity unit tests
## Branch
`feature/rip-2-pr6-messaging-integration`
### Describe Alternatives You've Considered
# [studio] feat: Admin Service Integration with Messaging Pipeline and E2E
Tests
## Background
This is the sixth and final atomic PR in the RIP-2 (Proxy Admin Interface)
series. It integrates the admin service with the existing messaging pipeline
(receipt handle management, channel tracking, message processing) and provides
end-to-end integration tests.
## Design Proposal
### Receipt Handle Management
- **ReceiptHandleManager** (interface): Admin-facing API for receipt handle
lifecycle queries and operations
- **DefaultReceiptHandleManager**: Implementation that wraps the existing
receipt handle processor, adding admin-specific query capabilities (list by
group, list by topic, TTL inspection)
### Messaging Pipeline Integration
- **GrpcMessagingActivity / DefaultGrpcMessagingActivity**: Extended to
expose client activity metrics to the admin service (message count, error rate,
last operation timestamp)
- **GrpcMessagingApplication**: Modified to register the admin service as an
observer of messaging lifecycle events
- **GrpcChannelManager / GrpcClientChannel**: Extended with admin query
methods — channel state inspection, pending request count, connection metadata
- **ClientActivity**: Enhanced to track per-client operation history for
admin diagnostics
### Processor Extension
- **MessagingProcessor / DefaultMessagingProcessor**: Added admin query
methods that aggregate broker-side state (topic config, subscription info) for
the admin API
- **ReceiptHandleProcessor**: Extended to support admin-initiated handle
inspection and forced expiration
### Infrastructure
- **WORKSPACE**: Updated Bazel workspace for integration test dependencies
- **SimpleChannel**: Minor fix for admin channel state reporting
### End-to-End Integration Test
- **ProxyAdminGrpcIT** (602 lines): Full-stack integration test that:
1. Starts a real Proxy instance with admin service enabled
2. Connects a gRPC admin client
3. Verifies all admin RPCs (ListClients, GetTopicRoute, WatchRouteChange,
etc.)
4. Tests authentication flow (valid/invalid tokens)
5. Validates streaming route change notifications
## Scope
| File | Type | Description |
|------|------|-------------|
| `ReceiptHandleManager.java` | New | Handle management interface |
| `DefaultReceiptHandleManager.java` | New | Handle management
implementation |
| `SimpleChannel.java` | Modified | Admin channel state fix |
| `DefaultGrpcMessagingActivity.java` | Modified | Admin metrics exposure |
| `GrpcMessagingActivity.java` | Modified | Interface extension |
| `GrpcMessagingApplication.java` | Modified | Admin observer registration |
| `GrpcChannelManager.java` | Modified | Admin query methods |
| `GrpcClientChannel.java` | Modified | Channel metadata for admin |
| `ClientActivity.java` | Modified | Operation history tracking |
| `DefaultMessagingProcessor.java` | Modified | Admin query aggregation |
| `MessagingProcessor.java` | Modified | Interface extension |
| `ReceiptHandleProcessor.java` | Modified | Admin handle inspection |
| `WORKSPACE` | Modified | Integration test dependencies |
| `AbstractRemotingActivityTest.java` | New | Remoting activity tests |
| `ProxyAdminGrpcIT.java` | New | E2E integration test (602 lines) |
**Total: 15 files, +1291 lines**
## Dependencies
- Depends on all previous PRs (#1–#5)
- This is the final integration PR that completes the RIP-2 implementation
## Testing
- E2E integration test covering all admin RPCs against a real Proxy instance
- Authentication flow verification (token-based and ACL-based)
- Streaming test for route change notifications
- Remoting activity unit tests
## Branch
`feature/rip-2-pr6-messaging-integration`
### Additional Context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
