RockteMQ-AI commented on issue #10635: URL: https://github.com/apache/rocketmq/issues/10635#issuecomment-5029703379
**Issue Evaluation** Category: `type/enhancement` | Status: **Evaluated** This is PR #4 of the RIP-2 series, implementing route change event detection and the server-streaming notification system. **Feasibility:** Feasible **Scope:** `proxy` module — route change detection, event bus, streaming RPC implementation **Compatibility:** No breaking changes — new streaming RPC is additive **Assessment:** - Well-structured (10 files, +2414 lines) with clear separation between detection, event bus, and streaming layers - The `RouteChangeDetector` design using `TopicConfigSerializeWrapper` diff is practical - Server-streaming RPC (`WatchRouteChange`) is the correct gRPC pattern for real-time notifications - Event bus with configurable debounce (default 500ms) prevents notification storms during bulk route updates - Client reconnection with `lastSeenEventId` replay is a thoughtful design for reliability - Unit tests cover detection accuracy, debounce behavior, and streaming lifecycle **Note:** The debounce mechanism should be reviewed for correctness — if a route change occurs during the debounce window, the detector should coalesce changes and emit a single notification with the latest state, not the first state. Also verify that the `lastSeenEventId` replay does not cause duplicate notifications on the client side. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
