RockteMQ-AI commented on issue #10661: URL: https://github.com/apache/rocketmq/issues/10661#issuecomment-5078770092
**Issue Evaluation** Category: `type/enhancement` | Status: **Confirmed** The reported issue has been verified against the current codebase. **Root Cause:** In `ClientActivity.notifyClientTermination()` (proxy module), the `grpcChannelManager.removeChannel(clientId)` call is inside the topic loop. After the first iteration removes the channel, subsequent iterations get `null` from `removeChannel`, so only the first publishing topic gets unregistered. **Location:** `proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/client/ClientActivity.java`, lines 162-169 **Proposed Fix:** Move `removeChannel(clientId)` outside the loop. Create the `ClientChannelInfo` once, then iterate over all topics to unregister the producer from each. **Impact:** Producers publishing to multiple topics will have all topics properly unregistered on termination, preventing stale registrations. **Severity:** Medium — can cause resource leaks and incorrect routing state for multi-topic producers. An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
