Aias00 opened a new pull request, #10679: URL: https://github.com/apache/rocketmq/pull/10679
### Summary - Reject empty `AckMessageRequest.entries` before checking the first entry for batch-ack routing. - Return a structured `GrpcProxyException(Code.BAD_REQUEST, ...)` for invalid empty ack requests. - Add a regression test covering empty entries with batch ack enabled. ### Motivation Closes #10678. `AckMessageActivity.ackMessage` previously evaluated `request.getEntries(0)` before validating that the request contains any entries. An empty ack request therefore triggered `IndexOutOfBoundsException`, which makes invalid client input look like an internal Proxy failure. ### Tests - `mvn -pl proxy -Dtest=AckMessageActivityTest -DfailIfNoTests=false test` Result: BUILD SUCCESS; 3 tests passed; checkstyle reported 0 violations. The run emits existing JaCoCo instrumentation warnings under the local JDK, but tests and build completed successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
