RockteMQ-AI commented on PR #10677: URL: https://github.com/apache/rocketmq/pull/10677#issuecomment-5113224613
## Review by github-manager-bot ### Summary Replaces full protobuf `TelemetryCommand` serialization in exception logs with a compact diagnostic summary, preventing sensitive data (e.g., thread stack traces) from leaking into log output. ### Findings - **[Info]** `ClientActivity.java:365` — The `summarizeTelemetryCommand` method correctly extracts diagnostic fields (command type, status code, nonce, client type) while omitting potentially sensitive payloads. - **[Info]** `ClientActivity.java:375-393` — The `switch` on `commandCase` is well-structured. `THREAD_STACK_TRACE` correctly includes only the nonce and omits the actual stack trace content. - **[Info]** `ClientActivityTest.java:420` — Test explicitly verifies that the secret stack trace string does NOT appear in the summary. Good negative assertion. ### Suggestions - **[Info]** Consider adding a `SETTINGS` case test that verifies `clientType` and `pubSubCase` appear in the summary, for completeness of the `switch` branch coverage. Minor — not blocking. --- *Automated review by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
