fuyou001 commented on PR #10694: URL: https://github.com/apache/rocketmq/pull/10694#issuecomment-5128557383
[P1] Please preserve the IPv6 scope/zone instead of stripping it unconditionally. For link-local IPv6 addresses (`fe80::/10`), the scope identifies the network interface and is required to select the correct destination. Removing `%scope` changes the address semantics and may make connection attempts fail or select the wrong interface. The current test uses a non-link-local address with a synthetic scope, so it only demonstrates that parsing succeeds after information is discarded. Please retain the scope and let `Inet6Address`/`InetSocketAddress` resolve a valid interface name or numeric scope. If the scope cannot be resolved, returning a clear parsing failure is safer than silently changing the address. Please add a parse-format-parse test for a link-local address with a real interface scope, a numeric scope-id case, malformed bracket and missing/out-of-range port cases, and IPv4/hostname/unscoped-IPv6 compatibility cases. Also, `socketAddress2String` changes the externally visible IPv6 representation to `[IPv6]:port`; please verify rolling-upgrade compatibility because an old node parsing a new node's bracketed output retains the leading `[` in the host string. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
