Aias00 opened a new issue, #10710:
URL: https://github.com/apache/rocketmq/issues/10710
### Before Creating the Bug Report
- [x] I found a bug, not just asking a question, which should be created in
GitHub Issues.
- [x] I have searched the existing issues and believe this is not a
duplicate.
- [x] I have confirmed that this bug belongs to the current repository.
### Describe the Bug
`GrpcClientSettingsManager#offlineClientLiteSubscription` logs the full gRPC
`Settings` object when cleanup fails:
```java
log.error("offlineClientLiteSubscription error, clientId:{}, settings:{}",
clientId, settings, e);
```
`Settings` can contain client runtime metadata, subscription details, metric
endpoint information, and future fields added by gRPC clients. Logging the
whole protobuf object is unnecessary for diagnostics and can leak more client
metadata than intended.
This is similar in spirit to recent telemetry log sanitization work, but
this path is separate from `TelemetryCommand` write/exception logging.
### Expected Behavior
Failure logs should keep useful diagnostic fields while avoiding full
protobuf serialization. For example, log only:
- client id
- client type
- consumer group
- first topic / topic count
- subscription count
The cleanup behavior should stay unchanged.
### Scope
RocketMQ Studio Track 2 / Proxy gRPC client diagnostics and safe operational
logging.
### Proposed Fix
Replace the full `settings:{}` log argument with a compact sanitized summary
helper, and add a regression test that verifies the summary does not include
full subscription/filter details while preserving diagnostic fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
