RockteMQ-AI commented on issue #10722:
URL: https://github.com/apache/rocketmq/issues/10722#issuecomment-5142193962

   **Issue Evaluation**
   
   Category: `type/bug` | Status: **Confirmed**
   
   The reported issue has been verified against the current codebase on the 
`develop` branch.
   
   **Root Cause:** In `AbstractLiteLifecycleManager#isLiteTopicExpired` (line 
183-184), `getMessageStoreTimeStamp(lmqName, 0, maxOffset - 1)` may return 0 or 
a negative value when the message at the given offset has been physically 
deleted or is temporarily unreadable. The code proceeds to compute 
`inactiveTime = System.currentTimeMillis() - latestStoreTime` without 
validating `latestStoreTime`, resulting in an extremely large `inactiveTime` 
that causes unreliable expiration judgment.
   
   **Impact:** Lite Topics may be incorrectly judged as expired (or not expired 
depending on the sign), leading to premature cleanup or resource leaks.
   
   **Severity:** Medium — affects Lite Topic lifecycle management under edge 
conditions (message deletion / store unavailability).
   
   **Suggested Fix:** Add a validity check for `latestStoreTime` after the 
`getMessageStoreTimeStamp` call. When `latestStoreTime <= 0`, treat the topic 
as potentially expired (consistent with the existing `maxOffset <= 0` handling 
pattern).
   
   An automated fix proposal will be generated. Reply `/approve` to proceed 
with PR generation.
   
   ---
   *Automated evaluation by RockteMQ-AI*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to