RockteMQ-AI commented on PR #10758:
URL: https://github.com/apache/rocketmq/pull/10758#issuecomment-5161427177

   Thanks for the clarification, @ai-yang. You're right — I can see that 
`truncateAllPending` is correctly reset to `false` at the end of the successful 
path in `truncateAll()` (after `setFlushedWhere(0)` and 
`setCommittedWhere(0)`). The early return on the failure path (files not fully 
deleted) intentionally keeps it `true` to gate new `put()` calls until a retry 
succeeds. My original warning was incorrect on this point; the design is sound. 
👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to