Copilot commented on code in PR #10777:
URL: https://github.com/apache/rocketmq/pull/10777#discussion_r3701939568
##########
proxy/src/test/java/org/apache/rocketmq/proxy/remoting/protocol/http2proxy/Http2ProtocolProxyHandlerTest.java:
##########
@@ -44,6 +49,8 @@ public class Http2ProtocolProxyHandlerTest {
@Before
public void setUp() throws Exception {
+ ConfigurationManager.initConfig();
+
ConfigurationManager.getProxyConfig().setEnableRemotingLocalProxyGrpc(true);
http2ProtocolProxyHandler = new Http2ProtocolProxyHandler();
Review Comment:
This test initializes `ConfigurationManager` directly, but most proxy unit
tests rely on `InitConfigTest` to set/clear `RMQ_PROXY_HOME` and to call
`initEnv()` before `initConfig()`. Aligning with that shared setup reduces
global-state leakage and makes the test less order-dependent with other proxy
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
