RockteMQ-AI commented on issue #10772: URL: https://github.com/apache/rocketmq/issues/10772#issuecomment-5163339951
**Issue Evaluation** Category: `type/bug` | Status: **Confirmed** The reported issue has been verified against the current codebase on the `develop` branch. **Root Cause:** In `DefaultAdminService.createTopicOnBroker`, the first loop over `curBrokerDataList` calls `brokerData.getBrokerAddrs().get(MixAll.MASTER_ID)` without a null check on `getBrokerAddrs()`. Interestingly, the second loop over `sampleBrokerDataList` already has the null guard: `brokerData.getBrokerAddrs() == null ? null : brokerData.getBrokerAddrs().get(MixAll.MASTER_ID)`. This inconsistency means malformed broker data in the current list can trigger an NPE. **Impact:** Topic creation can fail with NPE when broker metadata is inconsistent or partially initialized. **Severity:** medium A fix proposal can be generated. Reply with feedback if needed. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
