Copilot commented on code in PR #807:
URL:
https://github.com/apache/rocketmq-dashboard/pull/807#discussion_r3702000991
##########
web/src/pages/settings/index.tsx:
##########
@@ -212,7 +212,7 @@ const GeneralSettingsTab = () => {
{ value: 'openai', label: 'OpenAI' },
{ value: 'azure', label: 'Azure OpenAI' },
{ value: 'ollama', label: 'Ollama' },
- { value: 'qwen', label: '通义千问' },
+ { value: 'tongyi', label: '通义千问' },
]}
Review Comment:
The legacy Settings page loads `llmProvider` from `getGeneralSettings()` and
sets it into the form unchanged. If an existing installation has `llmProvider`
persisted as the legacy value `qwen`, this `<Select>` no longer contains that
option, so the field may render as blank/unknown and can also be re-saved as
`qwen` without the user noticing. Consider normalizing `qwen -> tongyi` when
populating form values (or before submit) to keep the UI consistent and migrate
stored configs forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
