Aias00 opened a new issue, #840: URL: https://github.com/apache/rocketmq-dashboard/issues/840
### What happened? AuthController passes the LoginDTO directly to AuthService, and AuthService logs request.getUsername before validating the request object. If a null LoginDTO reaches the service, the login path can throw NullPointerException instead of returning a clear client error. ### Expected behavior A missing login request body should be rejected with a clear 400 response, and AuthService should also guard against null requests for direct service callers. ### Why this matters This belongs to BASE-01 login and permission handling. Authentication endpoints should fail predictably and should not turn malformed client requests into server errors. ### Candidate fix - Make the controller reject null login request bodies with BusinessException 400 - Add a service-level null guard before logging fields - Add focused controller and service tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
