Aias00 opened a new issue, #10795:
URL: https://github.com/apache/rocketmq/issues/10795

   ### What happened?
   
   The Proxy remoting implementation of `RequestCode.CHECK_CLIENT_CONFIG` 
currently creates a success response without validating the request body.
   
   Broker-side handling validates `CheckClientRequestBody`, including filter 
expression type support and expression parse errors, and returns an error 
response when the client config is invalid. The Proxy remoting path should 
preserve that behavior instead of always returning success.
   
   ### Expected behavior
   
   Proxy remoting `CHECK_CLIENT_CONFIG` should decode and validate the request 
in the same way as the broker path, returning an error response for unsupported 
or invalid subscription expressions.
   
   ### Scope
   
   RocketMQ Proxy / remoting compatibility. This is related to the Proxy Admin 
and client diagnostics track because invalid client subscription configuration 
should be visible through the Proxy path.
   
   ### Suggested fix
   
   Decode `CheckClientRequestBody`, validate expression type and expression 
syntax, and return the corresponding remoting error code when validation fails.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to