RockteMQ-AI commented on issue #10810:
URL: https://github.com/apache/rocketmq/issues/10810#issuecomment-5190411159

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   **Root Cause:** `AuthenticationHandler` logs the full `Signature` header 
(including `SignatureValue`) on both success and error paths. This exposes the 
request signature in audit logs.
   **Impact:** Security — signature replay risk on log access
   **Severity:** Medium
   
   The issue is valid. The code at 
`proxy/src/main/java/org/apache/rocketmq/proxy/auth/AuthenticationHandler.java` 
lines 174-176 and 201-203 logs the raw `Signature` header. The proposed fix 
(masking `SignatureValue` while preserving `Credential` and `SignedHeaders`) is 
appropriate and follows the principle of least-privilege logging.
   
   An automated fix proposal will be generated. Reply `/approve` to proceed 
with PR generation.
   
   ---
   *Automated evaluation by @RockteMQ-AI*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to