RockteMQ-AI commented on issue #10806: URL: https://github.com/apache/rocketmq/issues/10806#issuecomment-5190413970
**Issue Evaluation** Category: `bug` | Status: **Confirmed** **Root Cause:** `RemotingExceptionHandler.handleExpired()` calls `future.release()` inside a try-catch that silently swallows `Throwable`. The `finally` block in `RequestTask.run()` also swallows `future.release()` failures. **Impact:** Operational — resource leaks and lost diagnostics when request cleanup fails **Severity:** Medium The issue is valid. Both the `handleExpired()` path and the `finally` block in `RequestTask.run()` need proper error handling. The proposed fix (logging at WARN level, completing futures exceptionally instead of releasing them) is correct. An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by @RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
