RockteMQ-AI commented on issue #1040: URL: https://github.com/apache/rocketmq-dashboard/issues/1040#issuecomment-5191581578
**Issue Evaluation** Category: `bug` | Status: **Not a Bug (as described)** Code verification found that the classes and methods referenced in this issue do not exist in the current codebase: - `RocketMQDashboardProvider` — does not exist - `RealClusterProvider` — does not exist - `RocketMQClusterProvider` — does not exist - `emptyDashboard()` — does not exist The actual dashboard architecture serves cached time-series data from files (`DashboardServiceImpl` reads from `DashboardCollectService` caches), not a live topology query with a single try/catch. **However**, real null-safety gaps do exist in different classes: | File | Line | Unguarded call | |------|------|----------------| | `DashboardCollectTask.java` | 110 | `clusterInfo.getBrokerAddrTable().entrySet()` | | `DashboardCollectTask.java` | 114 | `clusterEntry.getValue().getBrokerAddrs()` | | `ClusterServiceImpl.java` | 52 | `clusterInfo.getBrokerAddrTable().values()` | | `ClusterServiceImpl.java` | 54 | `brokerData.getBrokerAddrs().entrySet()` | | `TopicServiceImpl.java` | 126 | `clusterInfo.getBrokerAddrTable().values()` | | `TopicServiceImpl.java` | 128 | `brokerAddr.getBrokerAddrs().get(0L)` | These are genuine defensive-coding gaps that could cause NPEs, but they would cause exceptions to propagate (crashing scheduled tasks or API calls), not silently zero a dashboard overview page. **Recommendation:** This issue should be closed or revised with accurate class/method references. The real null-safety gaps could be addressed in a separate, accurately-described issue. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
