RockteMQ-AI commented on code in PR #1058:
URL:
https://github.com/apache/rocketmq-dashboard/pull/1058#discussion_r3726859947
##########
server/src/main/java/org/apache/rocketmq/studio/cluster/client/ProducerConnectionService.java:
##########
@@ -41,7 +41,7 @@ public List<ProducerConnectionVO> listConnections(String
topic, String producerG
}
public List<String> listProducerGroups() {
- return clientProvider.findConnections(null,
ClientType.Producer.name()).stream()
+ return clientProvider.findConnections(null, null,
ClientType.Producer.name()).stream()
Review Comment:
**[Warning]** This call now passes `null` for `instanceId`, which will cause
`RuntimeAdminClientResolver.execute()` to throw `BusinessException(400,
"instanceId is required")`. This method needs to be updated to either accept an
`instanceId` parameter or use a different code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
