RockteMQ-AI commented on PR #10805: URL: https://github.com/apache/rocketmq/pull/10805#issuecomment-5205492855
## 🤖 Automated Review by RockteMQ-AI ## Review Summary The change correctly reduces log volume by replacing raw object/string logging with compact summaries while preserving diagnostic fields. It is backward compatible behaviorally; only log output changes. The new regression test verifies the main privacy goal. ## Findings ### 🟡 Warning - **`proxy/.../AbstractSystemMessageSyncer.java:127`** — Default `summarizeSystemMessageData(Object)` returns the raw object unchanged. Other `AbstractSystemMessageSyncer` subclasses will continue logging full payloads until they override the method. - **`proxy/.../HeartbeatSyncer.java:222`** — Log field names changed (`data:` → `dataSummary:`, `subList:` → `subscriptionSummary:`) and raw subscription expressions / channel data are no longer emitted. This may break existing log parsers or alerts. - **`proxy/.../HeartbeatSyncer.java:154`** — `summarizeSubscriptionDataSet` streams `SubscriptionData::getTopic` without null safety. A null topic or null element in the set will throw NPE. Consider hardening with `filter(Objects::nonNull)` or `nullsFirst`. ### 🟢 Suggestion - **`proxy/.../HeartbeatSyncer.java:164`** — `summarizeSystemMessage(MessageExt msg)` is slightly misnamed; `summarizeMessageExt` would be clearer. - **`proxy/.../HeartbeatSyncerTest.java:218`** — Add null-input tests for `summarizeHeartbeatData(null)`, `summarizeSubscriptionDataSet(null)`, and the non-`HeartbeatSyncerData` dispatch path in `summarizeSystemMessageData`. - **`proxy/.../HeartbeatSyncer.java:154`** — Sorting topics adds `O(n log n)` overhead; if subscription sets can be large, consider skipping the sort. ## Verdict No critical issues. The PR is safe to merge after considering the log-format compatibility impact and optionally hardening null handling. --- <sub>Automated review. Please verify findings before acting on them.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
